Rick_denatale ri_cal → 0.0.8

Reported by Paul Scott-Murphy

I saw the following stack trace just now when testing an iCalendar
file.

TypeError: expected numeric or date

   from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/

ruby/1.8/date.rb:1220:in -'<br/>

   from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:

120:in send'<br/>

   from /Users/paulsm/Projects/ri_cal/lib/ri_cal/property_value/date.rb:

120:in method_missing'<br/>

   from /Users/paulsm/Projects/ri_cal/lib/ri_cal/

occurrence_enumerator.rb:163:in set_occurrence_properties!'<br/>

   from /Users/paulsm/Projects/ri_cal/lib/ri_cal/

occurrence_enumerator.rb:171:in recurrence'<br/>

   from /Users/paulsm/Projects/ri_cal/lib/ri_cal/

occurrence_enumerator.rb:105:in each'<br/>

   from /Users/paulsm/Projects/ri_cal/lib/ri_cal/

occurrence_enumerator.rb:118:in to_a'<br/>

   from /Users/paulsm/Projects/ri_cal/lib/ri_cal/

occurrence_enumerator.rb:118:in to_a'<br/>

   from /Users/paulsm/Projects/ri_cal/lib/ri_cal/

occurrence_enumerator.rb:137:in occurrences'<br/>

   from (irb):27
   from (irb):26:in `each'
   from (irb):26
   from :0

It looks like the use of method_missing in RiCal::PropertyValue::Date
isn't correct when invoking the - method, as the ::Date class requires
the argument sent to that method to be a ::Numeric or ::Date.

I added the following test for this in date_spec.rb:

describe ".-" do

 it "should return duration for two instances" do
   dt1 = RiCal::PropertyValue::Date.new(nil, :value =>

DateTime.parse("20090519"))

   dt2 = RiCal::PropertyValue::Date.new(nil, :value =>

DateTime.parse("20090518"))

   (dt1 - dt2).should == 1
 end

end

And made the test pass with this additional method in
RiCal::PropertyValue::Date

 def - (x)
   self.ruby_value - x.ruby_value
 end

There may be other instances of using the - or + methods on
RiCal::PropertyValue classes elsewhere too, which I haven't looked at.